We've split up the commands, scripting and mods, and add ons category! Please be sure you get your thread in the right place.

← Commands
6
Follow

Advancements can run functions as macro

Advancements that run functions now have an option to send event related data to the function in form of macro parameters.

Running functions from advancements is a very useful tool for datapack developers. Despite its many applications it is also
very limited in many situations. My suggestion aims to overcome these limits and make advancements much more versatile.

"rewards": {
  "function": {
    "path": "test:test_function",
    "send_event_data": true
  }
}

The send data depends on the type of trigger.
The consume_item trigger would have information about the player consuming the item as well as the item which was consumed.
The entity_hurt_player would have information about the player that was hurt, the attacking entity as well as the amount and type of damage dealt.

All this information could be accessed via macro parameters in the function.
The player parameter would contain all information about the player as NBT.
To access this information. The data would have to be put in a NBT storage first.

$data modify storage test:data player set value $(player)

This process could be made much easier by accessing the macro data directly which could be possible with this suggestion: 

https://feedback.minecraft.net/hc/en-us/community/posts/20914301800333-Access-macro-data-with-data-command 

Avatar
Registered User shared this idea

2 Comments

Please sign in to leave a comment.

Date Votes
Sorted by oldest
  • 2
    Registered User commented
    Comment actions Permalink

    This would add a lot of functionality. Think of adding custom scoreboard data and announcing it to the player just by doing something like (but in datapack advancement format):

    /function pack:currency {add:10}

    That way only one function has to be created to be used by normal functions and advancements.

  • 0
    Registered User commented
    Comment actions Permalink

    I don't see the use in accessing player nbt, since the function will be ran from the player getting the advancement. Something like the following would already be more than plenty useful: 

    "function": "datapack:function {\"value\":\"10\"}"

    This would keep the same structure, or something like:

    "function": {
        "path": "datapack:function",
        "macro": {
            "value": 10
        }
    }